Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/test_sft_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1829,7 +1829,12 @@ def test_train_vlm_gemma_3n(self):
)
@pytest.mark.parametrize(
"dataset_config",
["conversational_language_modeling", "conversational_prompt_completion", "standard_prompt_completion"],
[
"conversational_language_modeling",
"conversational_prompt_completion",
"standard_language_modeling", # Regression test for #5334
"standard_prompt_completion",
],
)
@require_vision
def test_train_vlm_text_only_data(self, model_id, dataset_config):
Expand Down
5 changes: 4 additions & 1 deletion trl/trainer/sft_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,10 @@ def tokenize_fn(example, processing_class, dataset_text_field, assistant_only_lo
processed = {k: v[0] if isinstance(v[0], list) else v for k, v in processed.items()}
output = {k: processed[k] for k in ("input_ids", "assistant_masks") if k in processed}
else:
output = {"input_ids": processing_class(text=example[dataset_text_field])["input_ids"]}
# Fix transformers inconsistency: for VLMs, processing_class returns lists of lists
# even for single examples, while for LLMs it returns lists of ints.
ids = processing_class(text=example[dataset_text_field])["input_ids"]
output = {"input_ids": ids[0] if isinstance(ids[0], list) else ids}

if "assistant_masks" in output and 1 not in output["assistant_masks"]:
raise RuntimeError(
Expand Down
Loading