Skip to content

Disable disk cache in hf_xet by default through cargo system. #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable disk cache in hf_xet by default through cargo system. #559

wants to merge 2 commits into from
+19 −36

Conversation

@hoytak
Copy link
Collaborator

@hoytak hoytak commented Nov 6, 2025

This PR disables the disk cache by default in hf_xet using cargo features instead of in-code logic.

Reverts #535

@hoytak hoytak requested review from rajatarya and seanses November 6, 2025 20:32
assafvayner
assafvayner approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@assafvayner assafvayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rajatarya
Copy link
Collaborator

rajatarya commented Nov 6, 2025

Oh, now I get this - love it! I think the only thing left is to back out the Some(0) parts of the previous commit. Do you want to handle that or do you want me to add to this PR/do a separate PR?

rajatarya
rajatarya reviewed Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@rajatarya rajatarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

I think the other part is to back out the Some(0) changes from my previous PR, and then do some quick sanity testing to verify things remain working as expected.

@hoytak
Copy link
Collaborator Author

hoytak commented Nov 6, 2025

Love this!

I think the other part is to back out the Some(0) changes from my previous PR, and then do some quick sanity testing to verify things remain working as expected.

This PR should fully revert that PR. Did I miss something? I don't see any Some(0) leftover here.

rajatarya
rajatarya approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@rajatarya rajatarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love it! :shipit:

@rajatarya
Copy link
Collaborator

rajatarya commented Nov 6, 2025

Love this!
I think the other part is to back out the Some(0) changes from my previous PR, and then do some quick sanity testing to verify things remain working as expected.

This PR should fully revert that PR. Did I miss something? I don't see any Some(0) leftover here.

My mistake, I clicked on the commit in the Slack message and only reviewed those changes - didn't see the full PR right away. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajatarya rajatarya rajatarya approved these changes

@seanses seanses seanses approved these changes

@assafvayner assafvayner assafvayner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hoytak @rajatarya @seanses @assafvayner