Adjust standalone release chart CSS #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use CSS variables from outside if present - Use light or dark theme - Add an outline to labels to improve readability (especially on incompatible background colours, and above the day line) - Reorder elements to improve readability (put text on top of the day line)
Owner
|
python.org with python#1708 image: https://hugovk-devguide.readthedocs.io/en/standalone-svg/_static/release-cycle.svg 
With this PR's image: https://hugovk-devguide--36.org.readthedocs.build/en/36/_static/release-cycle.svg 
The white-with-black-outline is a bit hard to read. |
Author
|
Does it look better with an explicit background? |
Owner
|
The years look good but the Python versions and "end-of-life" are still hard to read/invisible: 
|
Owner
|
Looks about the same? 
|
Owner
|
Now the years aren't visible :) 
|
Owner
|
Looking good now, thanks! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-devguide--36.org.readthedocs.build/