Skip to content

Don't pipe the spinner #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 1 commit into from
Jan 9, 2026
Merged

Don't pipe the spinner #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/norwegianblue/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import atexit
import logging
import platform
import sys

from termcolor import colored
from yaspin import yaspin
Expand Down Expand Up @@ -120,9 +121,12 @@ def main() -> None:
show_title = (args.show_title == "yes") or (
multiple_products and args.show_title != "no"
)

stream = sys.stdout if sys.stdout.isatty() else sys.stderr

for product in args.product:
try:
with yaspin(color="yellow"):
with yaspin(color="yellow", stream=stream):
output = norwegianblue.norwegianblue(
product=product,
format=args.formatter,
Expand All @@ -143,7 +147,7 @@ def main() -> None:
if answer not in ("", "y", "Y"):
print()
continue
with yaspin(color="yellow"):
with yaspin(color="yellow", stream=stream):
output = norwegianblue.norwegianblue(
product=suggestion,
format=args.formatter,
Expand Down
Loading