Skip to content

Fix tox extras=None validation#289

Merged
hugovk merged 1 commit intomainfrom
fix-tox-validation
Mar 1, 2026
Merged

Fix tox extras=None validation#289
hugovk merged 1 commit intomainfrom
fix-tox-validation

Conversation

@hugovk
Copy link
Owner

@hugovk hugovk commented Mar 1, 2026

tox 4.36.0 added extra validation:

Which caused the pinned runs to fail:

Run uvx --with tox-uv tox -e pins
pins: venv> /home/runner/work/_temp/setup-uv-cache/archive-v0/WaN7jz0jfp6uKMzXDt3xR/bin/uv venv -p /home/runner/work/_temp/setup-uv-cache/archive-v0/WaN7jz0jfp6uKMzXDt3xR/bin/python --allow-existing '--prompt=norwegianblue[pins]' --python-preference system /home/runner/work/norwegianblue/norwegianblue/.tox/pins
pins: install_deps> /home/runner/work/_temp/setup-uv-cache/archive-v0/WaN7jz0jfp6uKMzXDt3xR/bin/uv pip install -r requirements.txt
pins: failed with extras not found for package norwegianblue: none (available: tests)
  pins: FAIL code 1 (0.17 seconds)
  evaluation failed :( (0.21 seconds)

https://github.com/hugovk/norwegianblue/actions/runs/22537249267/job/65286847724?pr=288

@hugovk hugovk added the changelog: skip Exclude PR from release draft label Mar 1, 2026
@hugovk hugovk enabled auto-merge March 1, 2026 12:44
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (158f72b) to head (7e3b6fd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files           7        7           
  Lines         437      437           
=======================================
  Hits          431      431           
  Misses          6        6           
Flag Coverage Δ
macos-latest 98.62% <ø> (ø)
ubuntu-latest 98.62% <ø> (ø)
windows-latest 98.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk hugovk merged commit 557c61b into main Mar 1, 2026
56 checks passed
@hugovk hugovk deleted the fix-tox-validation branch March 1, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: skip Exclude PR from release draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant