-
-
Notifications
You must be signed in to change notification settings - Fork 812
[cmd] Allow for filtering about maps permissions in vmmap
#1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Grazfather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be useful. We might want to add this as a flag argument though, e.g. vmmap --perms rwx.
Maybe we could even support a 'don't care' e.g. r?? vs r--, the former allowing rw-, r-x, etc. Maybe a good idea for a followup.
|
I think if we put this behind a flag, we should do it for the other filters too? But I think the idea of |
|
I'm marking this as draft until #1120 is merged |
9394ed1 to
10cb8fa
Compare
hugsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this filter!
Just some minor changes (mostly docs & tests)
Co-authored-by: crazy hugsy <[email protected]>
Grazfather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
|
|
||
| Using perms: | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add this as an asset? Can we count on these sticking around forever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hugsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, minor things to change (mostly what Graz said) and we ship !
|
|
||
| Using perms: | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: crazy hugsy <[email protected]>

This CL allows for searching sections by their permissions. For instance, you could search for all rwx sections by typing
vmmap rwx.