Skip to content

Conversation

@ValekoZ
Copy link
Collaborator

@ValekoZ ValekoZ commented May 29, 2024

This CL allows for searching sections by their permissions. For instance, you could search for all rwx sections by typing vmmap rwx.

@github-actions
Copy link

🤖 Coverage update for 116e2be 🔴

Old New
Commit 757f5bb 116e2be
Score 71.5302% 71.4923% (-0.0379)

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be useful. We might want to add this as a flag argument though, e.g. vmmap --perms rwx.

Maybe we could even support a 'don't care' e.g. r?? vs r--, the former allowing rw-, r-x, etc. Maybe a good idea for a followup.

@ValekoZ
Copy link
Collaborator Author

ValekoZ commented Jun 2, 2024

I think if we put this behind a flag, we should do it for the other filters too?
Like --addr for searching addresses and --name for searching with the name?
I think the goal here is to make it easily useable, without too much friction (I guess that's why there is no --addr/--name?) so in order to stay consistent I think its better to keep it this way

But I think the idea of ? is great I'll do that :)

@github-actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 9ade706 🟢

Old New
Commit 757f5bb 9ade706
Score 71.5991% 71.5991% (0)

@github-actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 9394ed1 🟢

Old New
Commit 757f5bb 9394ed1
Score 71.5991% 71.5991% (0)

@ValekoZ ValekoZ added this to the next milestone Jun 3, 2024
@ValekoZ
Copy link
Collaborator Author

ValekoZ commented Jun 9, 2024

I'm marking this as draft until #1120 is merged

@ValekoZ ValekoZ marked this pull request as draft June 9, 2024 16:44
@github-actions
Copy link

🤖 Coverage update for 10cb8fa 🟢

Old New
Commit 5376d78 10cb8fa
Score 71.2662% 71.2662% (0)

@github-actions
Copy link

🤖 Coverage update for ad16e98 🟢

Old New
Commit 5376d78 ad16e98
Score 71.2662% 71.2662% (0)

@github-actions
Copy link

🤖 Coverage update for 3ed4e36 🟢

Old New
Commit 5376d78 3ed4e36
Score 71.2662% 71.2662% (0)

@github-actions
Copy link

🤖 Coverage update for ba83306 🟢

Old New
Commit 5376d78 ba83306
Score 71.2662% 71.2662% (0)

@ValekoZ ValekoZ marked this pull request as ready for review November 10, 2024 16:00
@ValekoZ ValekoZ requested review from Grazfather and hugsy November 10, 2024 16:01
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this filter!
Just some minor changes (mostly docs & tests)

@github-actions
Copy link

🤖 Coverage update for e604c6e 🟢

Old New
Commit 5376d78 e604c6e
Score 71.1786% 71.1786% (0)

@hugsy hugsy modified the milestones: 2025.01, next Jan 11, 2025
@github-actions
Copy link

🤖 Coverage update for 3d8378c 🔴

Old New
Commit 5376d78 3d8378c
Score 71.0775% 71.0582% (-0.0193)

@github-actions
Copy link

🤖 Coverage update for a680b01 🔴

Old New
Commit ee605f9 a680b01
Score 71.0775% 71.0582% (-0.0193)

@github-actions
Copy link

🤖 Coverage update for 9a51586 🔴

Old New
Commit ee605f9 9a51586
Score 71.0775% 71.0582% (-0.0193)

@github-actions
Copy link

🤖 Coverage update for e0dd7cc 🟢

Old New
Commit ee605f9 e0dd7cc
Score 71.0775% 71.0775% (0)

@github-actions
Copy link

🤖 Coverage update for 1965889 🔴

Old New
Commit ee605f9 1965889
Score 71.0775% 71.0582% (-0.0193)

@github-actions
Copy link

🤖 Coverage update for c3e9ce4 🟢

Old New
Commit ee605f9 c3e9ce4
Score 71.0775% 71.0775% (0)

@ValekoZ ValekoZ requested a review from hugsy May 10, 2025 15:57
Grazfather
Grazfather previously approved these changes May 10, 2025
Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!


Using perms:

![vmmap-perms](https://github.com/user-attachments/assets/c34822d3-2369-464f-aafa-87113b293174)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add this as an asset? Can we count on these sticking around forever?

Copy link
Owner

@hugsy hugsy May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆
Those don't render.

image

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, minor things to change (mostly what Graz said) and we ship !


Using perms:

![vmmap-perms](https://github.com/user-attachments/assets/c34822d3-2369-464f-aafa-87113b293174)
Copy link
Owner

@hugsy hugsy May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆
Those don't render.

image

Co-authored-by: crazy hugsy <[email protected]>
@github-actions
Copy link

🤖 Coverage update for 8a130ff 🔴

Old New
Commit ee605f9 8a130ff
Score 71.0775% 71.0582% (-0.0193)

@github-actions
Copy link

🤖 Coverage update for 5dd4515 🔴

Old New
Commit ee605f9 5dd4515
Score 71.0775% 71.0582% (-0.0193)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants