Add support for shipyard.rs to browser extension#280
Open
sn99 wants to merge 1 commit intohuhu:masterfrom
Open
Add support for shipyard.rs to browser extension#280sn99 wants to merge 1 commit intohuhu:masterfrom
sn99 wants to merge 1 commit intohuhu:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Can you give a shipyard.rs rust-docs example? Thanks. |
Author
|
There are no public repos on shipyard, it is user-authenticated. But these changes seem to work properly atleast on firefox.
|
Member
|
I'm hesitate to add this since shipyard.rs is a commercial company, I don't know how will other users think about this. |
Author
|
Would it be possible to put it behind an opt-in user config? It mostly feels useful to have on shipyard. |
Member
|
Unfortunately, it has been restricted by chrome api. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mainly wanted macro diagrams which seems to work on shipyard.rs now too.