Fix Home Assistant config flow for API-only SolisCloud authentication #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make portal username optional - Accept API secret as string or bytes - Prevent None values in config flow validation - Align config flow with SolisCloud API behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Home Assistant config flow validation issues when using
API-only SolisCloud authentication.
The SolisCloud API supports read-only access using API Key ID + API Secret
validation, resulting in setup errors.
Changes
Nonevalues in config validationContext
The issue was reproducible even with valid API credentials and was caused by
config flow validation rather than SolisCloud API authentication itself.