Skip to content

Comments

Release v0.6.0#90

Merged
dexhorthy merged 3 commits intomainfrom
release-v0.6.0
May 12, 2025
Merged

Release v0.6.0#90
dexhorthy merged 3 commits intomainfrom
release-v0.6.0

Conversation

@dexhorthy
Copy link
Contributor

@dexhorthy dexhorthy commented May 12, 2025

Important

Release v0.6.0 updates the ACP image tag, adds new CRD files, and fixes README formatting.

  • Version Update:
    • Update image tag to v0.6.0 in kustomization.yaml and latest.yaml.
  • CRD Additions:
    • Add v0.6.0-crd.yaml with detailed CRD definitions for Agent, ContactChannel, LLM, MCPServer, Task, ToolCall, and Tool.
    • Add v0.6.0.yaml with similar CRD definitions and additional Kubernetes resources like ServiceAccount, Role, ClusterRole, and Deployment.
  • README Fixes:
    • Fix formatting issues in README.md by adjusting misplaced single quotes in code blocks.

This description was created by Ellipsis for fd6769d. You can customize this summary. It will automatically update as commits are pushed.

@dexhorthy dexhorthy merged commit 2e41364 into main May 12, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to fd6769d in 1 minute and 56 seconds. Click for details.
  • Reviewed 3178 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. acp/config/manager/kustomization.yaml:7
  • Draft comment:
    Image tag updated to v0.6.0. Please verify that the downstream deployments and references to 'manager.yaml' and 'api_service.yaml' are compatible with this new tag.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify compatibility with downstream deployments and references, which falls under the rule of not asking the author to ensure compatibility or verify intentions. This is not a specific code suggestion or a request for a test, so it should be removed.
2. acp/config/release/v0.6.0-crd.yaml:15
  • Draft comment:
    The CRD definitions are comprehensive. Consider enhancing the 'additionalPrinterColumns' (e.g., adding summaries) for better kubectl outputs and ensuring that any breaking changes are documented.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment suggests an enhancement to improve the output of kubectl by adding summaries to additionalPrinterColumns. It also mentions documenting any breaking changes. The first part is a specific suggestion to improve the code, which is valid. However, the second part about documenting breaking changes is more of a general reminder and not specific to the code change, which violates the rules.
3. acp/config/release/v0.6.0.yaml:1625
  • Draft comment:
    Deployment health probes (/healthz and /readyz) appear correctly configured. Ensure these endpoints remain in sync with the manager’s implementation.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the author to ensure that two endpoints remain in sync with the manager's implementation. It is not a specific code suggestion or a request for a test, but rather a general reminder to ensure consistency. This falls under the rule of not asking the author to ensure behavior is intended or tested.
4. acp/config/release/v0.6.0.yaml:1
  • Draft comment:
    Ensure that all resource definitions (CRDs, RBAC, Services, and the Deployment) remain in sync with the v0.6.0 release changes, especially if any schema validations or labels have been updated.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that certain resources remain in sync with a specific release. It is not making a specific suggestion or pointing out a specific issue in the code. It falls under the category of asking the author to double-check things, which is against the rules.
5. README.md:66
  • Draft comment:
    Typographical note: change 'macos' to 'macOS' on line 66 for proper casing.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. README.md:1257
  • Draft comment:
    Typographical note: Consider revising the phrase 'Remove the any secrets:' on line 1257 to 'Remove any secrets:' for clarity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_etMn9e2ABlje4uH8

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

type: string
metadata:
type: object
spec:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the LLM CRD, consider adding conditional validation for provider-specific configurations (e.g. requiring 'vertex' settings if provider is 'vertex').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant