Skip to content

Comments

Revert "rollback latest to v0.5.1"#93

Merged
dexhorthy merged 1 commit intomainfrom
revert-92-rollback-v0.5.1
May 12, 2025
Merged

Revert "rollback latest to v0.5.1"#93
dexhorthy merged 1 commit intomainfrom
revert-92-rollback-v0.5.1

Conversation

@dexhorthy
Copy link
Contributor

@dexhorthy dexhorthy commented May 12, 2025

Reverts #92


Important

Reverts previous changes, updating configuration and deployment files to include new properties and update the image version to v0.6.1.

  • Revert Changes:
  • Configuration Updates:
    • Updates latest-crd.yaml and latest.yaml to include additional properties like description, subAgents, and contextWindow.
    • Adds validSubAgents and contextWindow to the schema in latest-crd.yaml.
  • Deployment:
    • Updates image version from v0.5.1 to v0.6.1 in latest.yaml.
    • Adds api port configuration to the deployment in latest.yaml.

This description was created by Ellipsis for 0e27f4c. You can customize this summary. It will automatically update as commits are pushed.

@dexhorthy dexhorthy merged commit 56677ee into main May 12, 2025
4 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 0e27f4c in 1 minute and 53 seconds. Click for details.
  • Reviewed 352 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. acp/config/release/latest.yaml:1738
  • Draft comment:
    Reverting the image version to v0.6.1: please confirm this update is fully compatible with the new CRD changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm compatibility, which violates the rule against asking for confirmation or ensuring behavior is intended. It does not provide a specific suggestion or point out a specific issue.
2. acp/config/release/latest-crd.yaml:52
  • Draft comment:
    Added an optional 'description' field in AgentSpec. Ensure downstream consumers properly handle the extra metadata.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that downstream consumers handle the extra metadata, which falls under the rule of not asking the author to ensure behavior is intended or tested. It doesn't provide a specific suggestion or point out a specific issue.
3. acp/config/release/latest-crd.yaml:90
  • Draft comment:
    Introduced the 'subAgents' array in AgentSpec. Verify that clients and controllers correctly process this new list.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. acp/config/release/latest-crd.yaml:842
  • Draft comment:
    The TaskSpec now includes a new 'contextWindow' array. Ensure its usage is mutually exclusive with 'userMessage' as documented.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
5. acp/config/release/latest-crd.yaml:909
  • Draft comment:
    Removal of 'userMessage' from the required list in TaskSpec: please confirm that tasks can validly omit this field when using 'contextWindow'.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
6. acp/config/release/latest.yaml:771
  • Draft comment:
    A new additional printer column 'Agent' (.spec.agentRef.name) has been added to the Task CRD. This enhancement improves visibility; please verify that it meets CLI expectations.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that the new printer column meets CLI expectations, which is a form of asking for confirmation or verification. This violates the rule against asking the PR author to confirm or ensure behavior. Therefore, this comment should be removed.

Workflow ID: wflow_yD0fGA8T31L7OEZK

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

required:
- name
type: object
contextWindow:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions require that contextWindow and userMessage are mutually exclusive. Consider adding explicit validation if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant