Skip to content

Update Stream dependency to 4.1.1#414

Draft
mikelittle wants to merge 3 commits intomasterfrom
issue-1723-update=stream-4.1.1
Draft

Update Stream dependency to 4.1.1#414
mikelittle wants to merge 3 commits intomasterfrom
issue-1723-update=stream-4.1.1

Conversation

@mikelittle
Copy link
Contributor

  • Change xwp/stream from ^4.0.2 to 4.1.1 in composer.json
  • Add Action Scheduler initialization before loading Stream plugin
  • Ensures Action Scheduler is properly registered before Stream initialization

Note: This temporarily uses dev-master for xwp/stream until the 4.1.1 tag is available.

- Change xwp/stream from ^4.0.2 to 4.1.1 in composer.json
- Add Action Scheduler initialization before loading Stream plugin
- Ensures Action Scheduler is properly registered before Stream initialization

Note: This temporarily uses `dev-master` for xwp/stream until the 4.1.1 tag is available.
@joehoyle
Copy link
Member

Hmm I think this is the first time we'd have Action Scheduler as a platform-wide dependency, so I think we might want to "address" that, as our Altis Cloud AS wreaks havoc with cavalcade-- mainly the amount of jobs it runs is very costly for us.

Is there any way to not have Stream use Action Scheduler?

@mikelittle
Copy link
Contributor Author

It looks like this is the PR that added the use of AS to erase log entries in the background.

I think AS is only kicked off when the admin says to erase records manually and the blog has more than 1M records (in which case it schedules the AS action)

Firstly, we remove the admin screen which allows that to be triggered and secondly, given that we write the logs to write only storage (always?), this functionality is not required on our platform.

We may be able to just turn off the scheduled action

But I also think AS sets up a cron to check itself as often as possible, we'd need to figure out how to turn that off too. (Maybe we already know how to handle that one)

We cannot just remove or not initialise AS, as Stream calls an AS function when initialising.

@joehoyle
Copy link
Member

Oof ok, that's a bit annoying! I do wonder if one of these days we need to implement an ActionShceduler shim that basically just no-ops and uses cron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants