Add linting and basic unit tests #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers helpers in the ACF and Blocks namespaces using mocks. Full test suite covering template parsing is to come.
Includes fixtures for parsing and replacing content in templates.
goldenapples
changed the title
goldenapples
force-pushed
the
add-unit-tests
branch
from
c97e5fe to
15f8397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a set of unit tests covering all the main plugin functionality, which runs using wp-env.
This also includes some updates to the synced pattern helper files that previously were hardcoded - rather than just building out a single synced pattern for every pattern that it's called on, this allows for specifying a key and title when calling
Synced_Patterns\get_or_create()- for example: you may want all posts in one post type to import with one synced pattern for a CTA section, but use a different synced pattern for posts in a different post type.Added bonus: these tests uncovered a few edge cases around markup sanitization that weren't defined or built out previously.