Deduplicate queryId for query loop blocks#10
Merged
roborourke merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
WordPress core does not deduplicate queryId when query loop blocks are duplicated, which breaks features that rely on unique IDs (e.g. exclude displayed posts, independent pagination). Editor: adds a HOC that assigns each query block a unique queryId derived from the current post ID and the block's index among all query blocks. Server-side: tracks used queryIds and only overrides duplicates, preserving original values for interoperability. Uses dynamic render_block_context filters with depth tracking to correctly handle nested query blocks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Playwright test results
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryIdin both the editor and during server-side rendering, fixing a WordPress core issue where duplicating a query loop copies thequeryIdwithout deduplicationBlockEditHOCrender_block_contextfilters with depth tracking for correct nested query block handlingTest plan
queryIdin the block attributesnpm run test:e2e— all 12 tests pass🤖 Generated with Claude Code