Open
Conversation
Collaborator
|
This is superceded now by #5, so should no longer be necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted an issues with our hubspot form implementation.
https://js-eu1.hs-scripts.com/123.js, but not doing the same for the form script. The default (js.) is North America. Should update that to match.js-eu1.orjs.. If you specify north america, you currently getjs-na1which works fine, but is not documented.https://js.hsforms.net/forms/v2.jsbut I can't find any mention of this file in the documentation. All references usehttps://js.hsforms.net/forms/embed/v2.js. update to match current documentation. Note actual files are currently identical.hbspt.forms.createthe docs don't say it's optional - and don't say what it defaults to. . This is "The region of the account where the form was created.". We currently do nothing with this value. But we should add it to the config and I think it should behave likeportalIdby allowing you to set on global or block level.I'm slightly unsure if there are there potential problems loading scripts from one region and then specifying the form for another?