feat: unlock intellisense for the finder component#1104
Merged
theofidry merged 4 commits intohumbug:mainfrom Jan 12, 2025
hirasso:feat/finder-intellisense
Merged
feat: unlock intellisense for the finder component#1104theofidry merged 4 commits intohumbug:mainfrom hirasso:feat/finder-intellisense
theofidry merged 4 commits intohumbug:mainfrom
hirasso:feat/finder-intellisense
Conversation
…lisense for the Finder component
…tellisense for the Finder component
…intellisense for the Finder component
…intellisense for the Finder component
Member
|
Thank you @hirasso!
I don't mind someone proposing an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1097
Before
After
.mdfilesscoper.inc.php.tplNotes
A few unrelated (whitespace only) formatting things slipped through in this PR. An .editorconfig or an automated lint step in a GitHub workflow would solve these kinds of issues and would make it easier for people to contribute to php-scoper. In my experience, an .editorconfig is usually enough.