Skip to content

Do not generate json file at runtime #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KAction wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not generate json file at runtime #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions versionwarning/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,13 @@ def generate_versionwarning_data_json(app, config=None, **kwargs):
if not os.path.exists(data_path):
os.mkdir(data_path)

with open(os.path.join(data_path, JSON_DATA_FILENAME), 'w') as f:
f.write(data)
# Generate json file during build, not at runtime. I am not sure about
# proper way to distinguish these cases, but if build went ok, at runtime
# this file would already exist, probably read-only.
out = os.path.join(data_path, JSON_DATA_FILENAME)
if not os.path.exists(out):
with open(os.path.join(data_path, JSON_DATA_FILENAME), 'w') as f:
f.write(data)

# Add the path where ``versionwarning-data.json`` file and
# ``versionwarning.js`` are saved
Expand Down