FoundationEssentials #50
Conversation
Add percentEncode functions from Foundation Replace Foundation imports with FoundationEssentials
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
===========================================
- Coverage 70.65% 56.92% -13.73%
===========================================
Files 15 17 +2
Lines 627 924 +297
===========================================
+ Hits 443 526 +83
- Misses 184 398 +214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Hummingbird server framework project | ||
| // | ||
| // Copyright (c) 2021-2022 the Hummingbird authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See hummingbird/CONTRIBUTORS.txt for the list of Hummingbird authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2023 - 2024 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// |
There was a problem hiding this comment.
License out of date, what repo did this originate from?
There was a problem hiding this comment.
It came from swift-foundation
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Hummingbird server framework project | ||
| // | ||
| // Copyright (c) 2021-2022 the Hummingbird authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See hummingbird/CONTRIBUTORS.txt for the list of Hummingbird authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2023 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// |
| import FoundationEssentials | ||
| import Dispatch | ||
| #else | ||
| import Foundation |
There was a problem hiding this comment.
I'm assuming import Foundation already re-exports Dispatch then?
There was a problem hiding this comment.
Check this PR from @sebsto swift-server/swift-aws-lambda-runtime#540. Possibly won't need this soon.
There was a problem hiding this comment.
You're importing Dispatch just for DispatchWallTime ?
There was a problem hiding this comment.
Yes I am. It is the test framework for hummingbird-lambda so we have to create our own LambdaContext which up until now has required DispatchWallTime. With your change we can get rid of this
Add percentEncode functions from Foundation
Replace Foundation imports with FoundationEssentials