Skip to content

Comments

Use NIOFileSystem#655

Draft
adam-fowler wants to merge 5 commits intomainfrom
nio-file-system
Draft

Use NIOFileSystem#655
adam-fowler wants to merge 5 commits intomainfrom
nio-file-system

Conversation

@adam-fowler
Copy link
Member

I've set this as a draft for the moment as while NonBlockingFileIO has been deprecated, NIOFileSystem still has an under bar prefix which indicates it has an unstable API.

@adam-fowler adam-fowler requested a review from Joannis as a code owner January 13, 2025 17:09
@adam-fowler adam-fowler marked this pull request as draft January 13, 2025 17:12
@github-actions
Copy link

github-actions bot commented Jan 13, 2025

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '181c3786eaa0' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

Router

Router:Echo metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 769 769 769 769 769 769 769 1026
pull_request 769 769 769 769 769 769 769 1035
Δ 0 0 0 0 0 0 0 9
Improvement % 0 0 0 0 0 0 0 9

Router:GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 468 468 468 468 468 468 468 2915
pull_request 468 468 468 468 468 468 468 2947
Δ 0 0 0 0 0 0 0 32
Improvement % 0 0 0 0 0 0 0 32

Router:Middleware metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 373 373 373 373 373 373 373 2726
pull_request 373 373 373 373 373 373 373 2682
Δ 0 0 0 0 0 0 0 -44
Improvement % 0 0 0 0 0 0 0 -44

Router:PUT metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 1272 1272 1272 1272 1272 1272 1272 801
pull_request 1272 1272 1272 1272 1272 1272 1272 791
Δ 0 0 0 0 0 0 0 -10
Improvement % 0 0 0 0 0 0 0 -10

Router:Parameters metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 718 718 718 718 718 718 718 2419
pull_request 718 718 718 718 718 718 718 2440
Δ 0 0 0 0 0 0 0 21
Improvement % 0 0 0 0 0 0 0 21

RouterBuilder:Middleware metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 372 372 372 372 372 372 372 2770
pull_request 372 372 372 372 372 372 372 2799
Δ 0 0 0 0 0 0 0 29
Improvement % 0 0 0 0 0 0 0 29

TrieRouter:LongPaths metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 11 11 11 11 11 11 11 244
pull_request 11 11 11 11 11 11 11 242
Δ 0 0 0 0 0 0 0 -2
Improvement % 0 0 0 0 0 0 0 -2

TrieRouter:Parameters metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 19 19 19 19 19 19 19 184
pull_request 19 19 19 19 19 19 19 186
Δ 0 0 0 0 0 0 0 2
Improvement % 0 0 0 0 0 0 0 2

TrieRouter:Routing metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 13 13 13 13 13 13 13 238
pull_request 13 13 13 13 13 13 13 236
Δ 0 0 0 0 0 0 0 -2
Improvement % 0 0 0 0 0 0 0 -2

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.22%. Comparing base (b4f73eb) to head (313ee30).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Hummingbird/Files/FileIO.swift 79.16% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   84.30%   84.22%   -0.09%     
==========================================
  Files         117      117              
  Lines        7716     7695      -21     
==========================================
- Hits         6505     6481      -24     
- Misses       1211     1214       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants