Omit lowercasing components and paths, and opt for case insensitive comparisons instead#749
Draft
Omit lowercasing components and paths, and opt for case insensitive comparisons instead#749
Conversation
…omparisons instead
8d609ed to
60bff89
Compare
|
✅ Pull request no significant performance differences ✅ SummaryNew baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Full Benchmark ComparisonComparing results between 'main' and 'pull_request'RouterRouter:Echo metricsMalloc (total): results within specified thresholds, fold down for details.
Router:GET metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
Router:PUT metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
RouterBuilder:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:LongPaths metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Routing metricsMalloc (total): results within specified thresholds, fold down for details.
|
f8ed7d7 to
ec77f90
Compare
ec77f90 to
9da9b0a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 83.79% 83.42% -0.38%
==========================================
Files 117 117
Lines 5993 6034 +41
==========================================
+ Hits 5022 5034 +12
- Misses 971 1000 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can we add a benchmark to verify this is performance improvement, on both long and short URIs. |
adam-fowler
reviewed
Dec 13, 2025
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| internal import Foundation |
Member
There was a problem hiding this comment.
Is it possible to use FoundationEssentials, caseInsensitiveCompare should be available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.