Skip to content

Comments

Add NonThrowingRouteHandlers trait#786

Draft
Cyberbeni wants to merge 1 commit intohummingbird-project:mainfrom
Cyberbeni:non_throwing_router
Draft

Add NonThrowingRouteHandlers trait#786
Cyberbeni wants to merge 1 commit intohummingbird-project:mainfrom
Cyberbeni:non_throwing_router

Conversation

@Cyberbeni
Copy link
Contributor

resolves #785

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.94%. Comparing base (892c964) to head (d22c834).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   82.97%   82.94%   -0.04%     
==========================================
  Files         124      124              
  Lines        6185     6185              
==========================================
- Hits         5132     5130       -2     
- Misses       1053     1055       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cyberbeni Cyberbeni marked this pull request as draft February 19, 2026 17:33
@Joannis
Copy link
Member

Joannis commented Feb 20, 2026

How about this alternative solution; Add an associatedtype RouteError: Error = any Error to RouterMethods

@Joannis
Copy link
Member

Joannis commented Feb 20, 2026

Not sure if that would be breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to remove throws keyword from RouterMethods handlers

2 participants