Skip to content

feat: sub-path exports #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: sub-path exports #1522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e65dbbc
organize utilities
AdrianGonz97 May 28, 2025
0c96c1a
direct imports
AdrianGonz97 May 28, 2025
c05794a
letter
AdrianGonz97 May 28, 2025
b395392
fix: shouldn't be exported
AdrianGonz97 May 28, 2025
8dd5394
fix: props type name
AdrianGonz97 May 28, 2025
d03dd8b
fix: another one
AdrianGonz97 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-auto.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<script lang="ts">
import { mergeProps } from "svelte-toolbelt";
import { useScrollAreaScrollbarAuto } from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";
import ScrollAreaScrollbarVisible from "./scroll-area-scrollbar-visible.svelte";
import PresenceLayer from "$lib/bits/utilities/presence-layer/presence-layer.svelte";

let { forceMount = false, ...restProps }: _ScrollbarStubProps = $props();
let { forceMount = false, ...restProps }: ScrollbarStubProps = $props();

const scrollbarAutoState = useScrollAreaScrollbarAuto();
const mergedProps = $derived(mergeProps(restProps, scrollbarAutoState.props));
Expand Down
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-hover.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
useScrollAreaScrollbarAuto,
useScrollAreaScrollbarHover,
} from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";
import ScrollAreaScrollbarVisible from "./scroll-area-scrollbar-visible.svelte";
import PresenceLayer from "$lib/bits/utilities/presence-layer/presence-layer.svelte";

let { forceMount = false, ...restProps }: _ScrollbarStubProps = $props();
let { forceMount = false, ...restProps }: ScrollbarStubProps = $props();

const scrollbarHoverState = useScrollAreaScrollbarHover();
const scrollbarAutoState = useScrollAreaScrollbarAuto();
Expand Down
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-scroll.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<script lang="ts">
import { mergeProps } from "svelte-toolbelt";
import { useScrollAreaScrollbarScroll } from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";
import ScrollAreaScrollbarVisible from "./scroll-area-scrollbar-visible.svelte";
import PresenceLayer from "$lib/bits/utilities/presence-layer/presence-layer.svelte";

let { forceMount = false, ...restProps }: _ScrollbarStubProps = $props();
let { forceMount = false, ...restProps }: ScrollbarStubProps = $props();

const scrollbarScrollState = useScrollAreaScrollbarScroll();

Expand Down
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-shared.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<script lang="ts">
import { mergeProps } from "svelte-toolbelt";
import { useScrollAreaScrollbarShared } from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";

let { child, children, ...restProps }: _ScrollbarStubProps = $props();
let { child, children, ...restProps }: ScrollbarStubProps = $props();

const scrollbarSharedState = useScrollAreaScrollbarShared();

Expand Down
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-visible.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<script lang="ts">
import { useScrollAreaScrollbarVisible } from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";
import ScrollAreaScrollbarX from "./scroll-area-scrollbar-x.svelte";
import ScrollAreaScrollbarY from "./scroll-area-scrollbar-y.svelte";

let { ...restProps }: Omit<_ScrollbarStubProps, "forceMount"> = $props();
let { ...restProps }: Omit<ScrollbarStubProps, "forceMount"> = $props();

const scrollbarVisibleState = useScrollAreaScrollbarVisible();
</script>
Expand Down
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-x.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
import { IsMounted } from "runed";
import { box, mergeProps } from "svelte-toolbelt";
import { useScrollAreaScrollbarX } from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";
import ScrollAreaScrollbarShared from "./scroll-area-scrollbar-shared.svelte";

let { ...restProps }: _ScrollbarStubProps = $props();
let { ...restProps }: ScrollbarStubProps = $props();

const isMounted = new IsMounted();

Expand Down
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/scroll-area/components/scroll-area-scrollbar-y.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
import { IsMounted } from "runed";
import { box, mergeProps } from "svelte-toolbelt";
import { useScrollAreaScrollbarY } from "../scroll-area.svelte.js";
import type { _ScrollbarStubProps } from "../types.js";
import type { ScrollbarStubProps } from "../types.js";
import ScrollAreaScrollbarShared from "./scroll-area-scrollbar-shared.svelte";

let { ...restProps }: _ScrollbarStubProps = $props();
let { ...restProps }: ScrollbarStubProps = $props();

const isMounted = new IsMounted();

Expand Down
2 changes: 1 addition & 1 deletion packages/bits-ui/src/lib/bits/scroll-area/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ export type ScrollAreaCornerPropsWithoutHTML = WithChild;
export type ScrollAreaCornerProps = ScrollAreaCornerPropsWithoutHTML &
Without<BitsPrimitiveDivAttributes, ScrollAreaCornerPropsWithoutHTML>;

export type _ScrollbarStubProps = Omit<ScrollAreaScrollbarProps, "orientation" | "ref" | "id"> & {
export type ScrollbarStubProps = Omit<ScrollAreaScrollbarProps, "orientation" | "ref" | "id"> & {
Copy link
Collaborator Author

@AdrianGonz97 AdrianGonz97 May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting this here since it seems like it was mistakenly named with a _ prefix

id: string;
};