Updated library dio-http-cache to flutter 2.8 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this one. That would be nice to merge it asap 🙏 |
|
来信已收到
|
|
Any update on this @hurshi @agniswarmandal ? |
clragon
suggested changes
May 1, 2022
| flutter: | ||
| sdk: flutter | ||
| json_serializable: ^4.1.4 | ||
| json_serializable: ^6.1.4 |
There was a problem hiding this comment.
json_serializable should be in dev_dependencies not the normal dependencies,
because its not needed when compiling.
this will also prevent conflicts in the future.
There was a problem hiding this comment.
@agniswarmandal can you update this PR based on @clragon's comment?
|
来信已收到
|
|
@hurshi this PR looks LGTM. Can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Library to flutter 2.8