fix: correct SPARK_ON_K8S_IN_CLUSTER boolean parsing from env var#144
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: correct SPARK_ON_K8S_IN_CLUSTER boolean parsing from env var#144hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
`bool(getenv("SPARK_ON_K8S_IN_CLUSTER", False))` always evaluates to
True when the env var is set because getenv returns a string and
bool("false") is True. Use string comparison instead.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bool(getenv("SPARK_ON_K8S_IN_CLUSTER", False))always evaluates toTruewhen the env var is set to any value (including"false") becausegetenvreturns a string andbool("false")isTruegetenv(...).lower() == "true"for correct boolean parsing, consistent with howSPARK_ON_K8S_UI_REVERSE_PROXYis already handledTest plan
SPARK_ON_K8S_IN_CLUSTER=falsecorrectly evaluates toFalseSPARK_ON_K8S_IN_CLUSTER=truecorrectly evaluates toTrueFalse🤖 Generated with Claude Code