fix: correct --logs CLI option default comparison value#145
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: correct --logs CLI option default comparison value#145hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
The logs option compared against "logs" (plural) but the SparkAppWait enum uses "log" (singular), so the default was never True from env config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--logsCLI option default compared against"logs"(plural) butSparkAppWait.LOGis"log"(singular)SPARK_ON_K8S_APP_WAITER=logwould never activate the--logsflag by defaultTest plan
SPARK_ON_K8S_APP_WAITER=logcorrectly sets--logsdefault toTrueSPARK_ON_K8S_APP_WAITER=no_waitkeeps--logsdefault asFalse🤖 Generated with Claude Code