fix: resolve should_print from NOTSET to False default#149
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: resolve should_print from NOTSET to False default#149hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
The should_print parameter was never resolved from NOTSET. Since ArgNotSet() is truthy, this caused unintended printing to stdout instead of logging when callers didn't explicitly pass should_print. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should_printinsubmit_appwas never resolved from itsNOTSETsentinel value to an actual booleanArgNotSet()is truthy, soLoggingMixin.log()would callprint()instead of using the logger when callers didn't explicitly passshould_print=FalseTest plan
submit_app()withoutshould_printuses the logger (not stdout)submit_app(should_print=True)still prints to stdout🤖 Generated with Claude Code