Skip to content

fix: correct misleading warning in _parse_app_name_and_id #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hussein-awala wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: correct misleading warning in _parse_app_name_and_id #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spark_on_k8s/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,8 @@ def _parse_app_name_and_id(
if app_name != original_app_name:
self.log(
msg=(
f"Application name {original_app_name} is too long"
f" and will be truncated to {app_name}"
f"Application name {original_app_name!r} has been sanitized"
f" to {app_name!r} to comply with Kubernetes naming conventions"
),
level=logging.WARNING,
should_print=should_print,
Expand Down
Loading