Skip to content

fix: remove redundant leading-dash regex in _parse_app_name_and_id #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hussein-awala wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: remove redundant leading-dash regex in _parse_app_name_and_id #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions spark_on_k8s/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,7 @@ def _parse_app_name_and_id(
app_name = re.sub(r"[^0-9a-zA-Z]+", "-", app_name)
# Remove leading non-alphabetic characters
app_name = re.sub(r"^[^a-zA-Z]*", "", app_name)
# Remove leading and trailing dashes
app_name = re.sub(r"^-*", "", app_name)
# Remove trailing dashes
app_name = re.sub(r"-*$", "", app_name)
app_id = app_name + app_id_suffix_str
if app_name != original_app_name:
Expand Down
Loading