Open
Conversation
Kakadus
force-pushed
the
various-bugfixes
branch
from
561cdc7 to
82467c0
Compare
Kakadus
force-pushed
the
various-bugfixes
branch
from
82467c0 to
2a47be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first very small patch makes sure to forward the ns3 settings variable to the simulation upon subsequent resets.
Then, we replace all invalid uses of
self.aciton_spacetospaceDescinstead. We guarantee correct implementation by declaring_pack_dataa classmethod.Lastly, we set the dtypes of the numpy arrays specifically. Alternativly, it is not correctly set: e.g.
float32gets converted tofloat64