Skip to content

fix: surface download errors on files pages #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiangmuran wants to merge 2 commits into from
Closed

fix: surface download errors on files pages #1124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37cde1a
fix: surface download errors for files pages
jiangmuran Feb 4, 2026
2dcfa57
fix: guard error formatting for download failures
jiangmuran Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/ui-default/pages/problem_config.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,15 @@ const page = new NamedPage('problem_config', () => {

async function handleClickDownloadAll() {
const files = reduxStore.getState().testdata.map((i) => i.name);
const { links, pdoc } = await request.post('./files', { operation: 'get_links', files, type: 'testdata' });
const targets: { filename: string, url: string }[] = [];
for (const filename of Object.keys(links)) targets.push({ filename, url: links[filename] });
await download(`${pdoc.docId} ${pdoc.title}.zip`, targets);
try {
const { links, pdoc } = await request.post('./files', { operation: 'get_links', files, type: 'testdata' });
const targets: { filename: string, url: string }[] = [];
for (const filename of Object.keys(links)) targets.push({ filename, url: links[filename] });
await download(`${pdoc.docId} ${pdoc.title}.zip`, targets);
} catch (error) {
const err = error as any;
Notification.error(err.params ? [err.message, ...err.params].join(' ') : err.message);
}
}

async function uploadConfig(config: object) {
Expand Down
13 changes: 9 additions & 4 deletions packages/ui-default/pages/problem_files.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,15 @@ const page = new NamedPage('problem_files', () => {
const type = $(ev.currentTarget).closest('[data-type]').attr('data-type');
const files = ensureAndGetSelectedFiles(type);
if (files === null) return;
const { links, pdoc } = await request.post('', { operation: 'get_links', files, type });
const targets = [];
for (const filename of Object.keys(links)) targets.push({ filename, url: links[filename] });
await download(`${pdoc.docId} ${pdoc.title} ${type}.zip`, targets);
try {
const { links, pdoc } = await request.post('', { operation: 'get_links', files, type });
const targets = [];
for (const filename of Object.keys(links)) targets.push({ filename, url: links[filename] });
await download(`${pdoc.docId} ${pdoc.title} ${type}.zip`, targets);
} catch (error) {
const err = error as any;
Notification.error(err.params ? [err.message, ...err.params].join(' ') : err.message);
}
}

async function handleGenerateTestdata(ev) {
Expand Down
Loading