feat(hydro_lang): make network channels configurable with a generic Stream::send API
#2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydro with
|
| Latest commit: |
c3e6da2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb3375b0.hydroflow.pages.dev |
| Branch Preview URL: | https://pr2400.hydroflow.pages.dev |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
shadaj
force-pushed
the
pr2400
branch
2 times, most recently
from
b26b85b to
35a54d6
Compare
| .values() | ||
| .map(q!(|n| n + 1)) | ||
| .send_bincode(p5) | ||
| .send(p5, TCP.bincode()) |
Member
There was a problem hiding this comment.
.send(p5, TCP(BINCODE))
Tcp::with(bincode)
brainstorming
MingweiSamuel
approved these changes
Jan 5, 2026
Member
MingweiSamuel
left a comment
MingweiSamuel
left a comment
There was a problem hiding this comment.
Bikeshedding to do as you please
shadaj
force-pushed
the
pr2400
branch
4 times, most recently
from
373a1ae to
45e7346
Compare
Member
Author
|
Ended up deciding to do the whole refactor rather than having a half-migrated state. |
…Stream::send` API This eliminates the hardcoding of networking APIs to specific serialzation formats, transport protocols, etc. Includes similar refactors across `demux` / `round_robin` / etc APIs.
davidchuyaya
approved these changes
Jan 6, 2026
luckyworkama
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the hardcoding of networking APIs to specific serialization formats, transport protocols, etc. Includes similar refactors across
demux/round_robin/ etc APIs.