Skip to content

fix(hydro_std): Latency calculation fix #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidchuyaya merged 2 commits into from
Feb 7, 2026
Merged

fix(hydro_std): Latency calculation fix #2558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bdb461
Latency calculation fix
davidchuyaya Feb 6, 2026
71926b4
cargo insta
davidchuyaya Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hydro_std/src/bench_client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ where
.map(q!(|output| (SystemTime::now(), output)));

start_times
.defer_tick() // Get the start_times before they were overwritten with the newly generated input
.join_keyed_singleton(end_times_and_output)
.map(q!(|(start_time, (end_time, output))| (output, end_time.duration_since(start_time).unwrap())))
.into_keyed_stream()
Expand Down
42 changes: 26 additions & 16 deletions hydro_test/src/cluster/snapshots/paxos_ir.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7415,32 +7415,42 @@ expression: built.ir()
inner: Join {
left: Cast {
inner: Cast {
inner: Batch {
inner: Map {
f: stageleft :: runtime_support :: fn1_type_hint :: < (u32 , i32) , (u32 , std :: time :: SystemTime) > ({ use hydro_lang :: __staged :: __deps :: * ; use hydro_lang :: __staged :: live_collections :: keyed_singleton :: * ; let f__free = stageleft :: runtime_support :: fn1_type_hint :: < i32 , std :: time :: SystemTime > ({ use hydro_std :: __staged :: __deps :: * ; use hydro_std :: __staged :: bench_client :: * ; | _input | SystemTime :: now () }) ; { let orig = f__free ; move | (k , v) | (k , orig (v)) } }),
input: ReduceKeyed {
f: stageleft :: runtime_support :: fn2_borrow_mut_type_hint :: < i32 , i32 , () > ({ use hydro_std :: __staged :: __deps :: * ; use hydro_std :: __staged :: bench_client :: * ; | curr , new | { * curr = new ; } }),
input: ObserveNonDet {
inner: Tee {
inner: <tee 17>,
inner: DeferTick {
input: Batch {
inner: Map {
f: stageleft :: runtime_support :: fn1_type_hint :: < (u32 , i32) , (u32 , std :: time :: SystemTime) > ({ use hydro_lang :: __staged :: __deps :: * ; use hydro_lang :: __staged :: live_collections :: keyed_singleton :: * ; let f__free = stageleft :: runtime_support :: fn1_type_hint :: < i32 , std :: time :: SystemTime > ({ use hydro_std :: __staged :: __deps :: * ; use hydro_std :: __staged :: bench_client :: * ; | _input | SystemTime :: now () }) ; { let orig = f__free ; move | (k , v) | (k , orig (v)) } }),
input: ReduceKeyed {
f: stageleft :: runtime_support :: fn2_borrow_mut_type_hint :: < i32 , i32 , () > ({ use hydro_std :: __staged :: __deps :: * ; use hydro_std :: __staged :: bench_client :: * ; | curr , new | { * curr = new ; } }),
input: ObserveNonDet {
inner: Tee {
inner: <tee 17>,
metadata: HydroIrMetadata {
location_id: Cluster(loc3v1),
collection_kind: KeyedStream {
bound: Unbounded,
value_order: NoOrder,
value_retry: ExactlyOnce,
key_type: u32,
value_type: i32,
},
},
},
trusted: false,
metadata: HydroIrMetadata {
location_id: Cluster(loc3v1),
collection_kind: KeyedStream {
bound: Unbounded,
value_order: NoOrder,
value_order: TotalOrder,
value_retry: ExactlyOnce,
key_type: u32,
value_type: i32,
},
},
},
trusted: false,
metadata: HydroIrMetadata {
location_id: Cluster(loc3v1),
collection_kind: KeyedStream {
collection_kind: KeyedSingleton {
bound: Unbounded,
value_order: TotalOrder,
value_retry: ExactlyOnce,
key_type: u32,
value_type: i32,
},
Expand All @@ -7451,14 +7461,14 @@ expression: built.ir()
collection_kind: KeyedSingleton {
bound: Unbounded,
key_type: u32,
value_type: i32,
value_type: std :: time :: SystemTime,
},
},
},
metadata: HydroIrMetadata {
location_id: Cluster(loc3v1),
location_id: Tick(19, Cluster(loc3v1)),
collection_kind: KeyedSingleton {
bound: Unbounded,
bound: Bounded,
key_type: u32,
value_type: std :: time :: SystemTime,
},
Expand Down
Loading
Loading