Open
Conversation
daniel-slaugh
approved these changes
Nov 25, 2025
Contributor
daniel-slaugh
left a comment
There was a problem hiding this comment.
Looks good. A couple notes as I was reading through the files:
- hs.things.list() will return the response envelope for only the first page of items. If you want to get the full list use .listAll() to get it in a response envelope or .listAllItems() to unwrap it and get just the full list of items or null
- There's a TODO in the router/guards for thing.ownsThing. The thing schema no longer has ownsThing since all access control is handled on the workspace level now. Take a look at the router.ts file in the data-management-app for how to route based on AllAuth flows if you need this functionality before Ken and I implement OpenIDConnect here in 2 or 3 months.
- Optional personal preference but @hydroserver/client exposes a createHydroServer convenience function that will create a global hs instance for you and manage the a persisted session so you don't have to save hs in a Pinia store and import the store and pinia helpers in each component. See the data-management-app main.ts if you're interested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates HydroServer TypeScript client (https://www.npmjs.com/package/@hydroserver/client).