feat: sync with openiap v1.3.15 - simplify Android input field names#3129
feat: sync with openiap v1.3.15 - simplify Android input field names#3129
Conversation
Breaking Changes: - Android input type fields no longer need Android suffix: - obfuscatedAccountIdAndroid → obfuscatedAccountId - obfuscatedProfileIdAndroid → obfuscatedProfileId - purchaseTokenAndroid → purchaseToken - replacementModeAndroid → replacementMode New Features: - Add offerToken support for one-time purchase discounts (Android 7.0+) Changes: - Update openiap-versions.json (gql: 1.3.15, apple: 1.3.13, google: 1.3.26) - Regenerate TypeScript types - Update Nitro spec with new field names - Update Android native code (HybridRnIap.kt) - Update TypeScript API layer (src/index.ts) - Update example apps to use google key instead of android - Update documentation with cross-platform examples - Add release blog post Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAndroid input field names no longer include the "Android" suffix (e.g., Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @hyochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Android in-app purchase API by simplifying input field names and introducing support for one-time purchase discount offers. It also updates underlying OpenIAP dependencies to their latest versions, ensuring compatibility and leveraging new features. The changes aim to make the API more intuitive for developers while expanding functionality for Android users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
==========================================
+ Coverage 67.61% 67.63% +0.01%
==========================================
Files 9 9
Lines 1717 1721 +4
Branches 574 576 +2
==========================================
+ Hits 1161 1164 +3
- Misses 551 552 +1
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…s to llms.txt - Add subscription upgrade/downgrade example with purchaseToken and replacementMode - Add one-time purchase discount example with offerToken (Android 7.0+) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request simplifies the Android input type field names by removing the redundant Android suffix and aligns platform keys to google instead of android, which are great improvements for API consistency. It also adds support for offerToken for one-time purchase discounts on Android. The changes are consistently applied across the codebase, including source files, documentation, examples, and tests. I have one minor suggestion to improve code style in the new blog post. Overall, this is a solid pull request.
- Add standardized-offer-types.test.ts matching expo-iap test coverage - Tests DiscountOffer, SubscriptionOffer type structures - Tests input field naming convention (no Android suffix for inputs) - Tests offerToken for one-time purchase discounts - Fix nullable VerifyPurchaseWithProviderProps in HybridRnIap.kt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Androidsuffix)offerTokensupport for one-time purchase discounts (Android 7.0+)Breaking Changes
Fields inside
RequestPurchaseAndroidPropsandRequestSubscriptionAndroidPropsno longer needAndroidsuffix:obfuscatedAccountIdAndroidobfuscatedAccountIdobfuscatedProfileIdAndroidobfuscatedProfileIdpurchaseTokenAndroidpurchaseTokenreplacementModeAndroidreplacementModeNote: Response types (like
PurchaseAndroid.purchaseTokenAndroid) keep their suffix.Migration
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.