Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Fix AllProductsScreen and product fetching logic#11

Merged
hyochan merged 4 commits intomainfrom
fix/all-products-screen
Sep 27, 2025
Merged

Fix AllProductsScreen and product fetching logic#11
hyochan merged 4 commits intomainfrom
fix/all-products-screen

Conversation

@hyochan
Copy link
Member

@hyochan hyochan commented Sep 27, 2025

Summary

  • Fixed AllProductsScreen connection and retry logic
  • Improved product fetching to properly handle InApp and Subs types separately
  • Enhanced OpenIapStore to merge products instead of replacing them

Changes

  • Added proper connection initialization with activity context in AllProductsScreen
  • Fixed product fetching by using separate calls for InApp and Subs types instead of ProductQueryType.All
  • Updated OpenIapStore fetchProducts to merge products with existing ones to prevent data loss
  • Implemented unified product display with type badges ('in-app' and 'subs')
  • Added proper cleanup on screen disposal

Test plan

  • Build and run the app
  • Navigate to AllProductsScreen
  • Verify products display correctly with proper type badges
  • Test retry functionality when not connected
  • Confirm both in-app and subscription products appear

- Add AllProductsScreen with proper connection initialization and cleanup
- Fix product fetching to use separate calls for InApp and Subs types
- Improve OpenIapStore to merge products instead of replacing them
- Display all products in single list with type badges
- Add proper error handling and retry logic
@hyochan hyochan added the 🛠 bugfix All kinds of bug fixes label Sep 27, 2025
@hyochan hyochan force-pushed the fix/all-products-screen branch from 1090570 to 822e5a0 Compare September 27, 2025 06:15
- Update OpenIapModule to handle ProductQueryType.All by combining products
- Remove FetchProductsResultAll import from OpenIapStore
- When type=All, return combined products as FetchProductsResultProducts
- Add toProduct import for subscription to product conversion
@hyochan hyochan force-pushed the fix/all-products-screen branch from 312474d to cd53878 Compare September 27, 2025 08:27
@hyochan hyochan merged commit 4736255 into main Sep 27, 2025
4 checks passed
@hyochan hyochan deleted the fix/all-products-screen branch September 27, 2025 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🛠 bugfix All kinds of bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant