move overscan to RowsRangeProvider and make row ranges more explicit #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the row range management in the virtual scrolling table by moving the overscan logic from the Scroller component to the RowsAndColumnsProvider and introducing explicit naming for three distinct row ranges:
- Moves
overscanparameter fromScrollertoRowsAndColumnsProvider - Introduces three explicitly named row ranges:
visibleRowsRange,fetchedRowsRange, andrenderedRowsRange - Updates all components to use the new explicit range names
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/providers/RowsAndColumnsProvider.tsx | Adds overscan parameter and computes three explicit row ranges (visible, fetched, rendered); updates fetch logic to use fetchedRowsRange |
| src/contexts/RowsAndColumnsContext.ts | Updates interface to expose three explicit row ranges instead of a single range with padding; improves documentation with inline comments |
| src/components/HighTable/Wrapper.tsx | Passes overscan to RowsAndColumnsProvider instead of Scroller; removes unused ScrollerProps import |
| src/components/HighTable/Slice.tsx | Updates to use fetchedRowsRange and renderedRowsRange from context; recalculates padding rows based on the difference between fetched and rendered ranges |
| src/components/HighTable/Scroller.tsx | Removes overscan parameter and logic; computes only the visible row range without overscan; updates to use new range names from context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
severo
added a commit
that referenced
this pull request
Jan 1, 2026
severo
added a commit
that referenced
this pull request
Jan 2, 2026
severo
added a commit
that referenced
this pull request
Jan 2, 2026
…mplemented (#364) * add stories * update comments * update README (should have been in #367) * [refactor] prepare for two scrolling modes: native/virtual * update state only if start or end changed * [refactor] split scrollHeight into tableHeight and canvasHeight * set virtual mode (not implemented) if height is over 8M pixels * move constants.ts to helpers/ * [refactor] create ScrollModeProvider and add 'virtual' mode, not implemented * apply relevant copilot comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.