created issue #29

severo · severo · commit 057dc88ca68b · 2024-11-07T11:41:25.000+01:00
diff --git a/packages/components/src/workers/parquetWorkerClient.ts b/packages/components/src/workers/parquetWorkerClient.ts
@@ -165,7 +165,6 @@ export function compare<T>(a: T, b: T): number {
   return 1 // TODO: how to handle nulls?
 }
 
-// TODO(SL): once the types in cachedAsyncBuffer are fixed, import all the following from hyparquet
 type Awaitable<T> = T | Promise<T>;
 
 function cachedAsyncBuffer(asyncBuffer: AsyncBuffer): AsyncBuffer {

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,6 @@ export function compare<T>(a: T, b: T): number {`
`165`	`165`	`return 1 // TODO: how to handle nulls?`
`166`	`166`	`}`
`167`	`167`
`168`		`-// TODO(SL): once the types in cachedAsyncBuffer are fixed, import all the following from hyparquet`
`169`	`168`	`type Awaitable<T> = T \| Promise<T>;`
`170`	`169`
`171`	`170`	`function cachedAsyncBuffer(asyncBuffer: AsyncBuffer): AsyncBuffer {`