Skip to content

Conversation

@severo
Copy link
Contributor

@severo severo commented Mar 4, 2025

see #119

  • use vite to build a static app
  • move cli to a bin/ directory that includes the node scripts
  • ensure that we expose what is required by library clients + "bin" key in package
  • configure eslint and typescript to check bin/ and src/ (and test/bin) as expected
  • fix the worker (it was done automatically with vite build - now we don't rely on vite for the library, only for the app). The current state is that the worker is not bundled, it's a normal module, but when included, the dependencies are not resolved (my guess).

@severo severo marked this pull request as ready for review March 5, 2025 09:41
@severo severo requested a review from platypii March 5, 2025 09:41
Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, tested locally 👍 Thanks for re-integrating these packages!

@severo severo merged commit 6a31a27 into master Mar 5, 2025
4 checks passed
@severo severo deleted the 119-merge-components-with-hyperparam branch March 5, 2025 20:02
@platypii platypii linked an issue Mar 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge packages/components to packages/cli?

3 participants