Use a global Config context instead of passing props along all the components #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm merging to keep working on the config and CSS modules. Using the context is much better than the previous situation where we passed the props down. I'm not publishing a new version on npm yet, so, we can rework this afterward if needed cc @platypii |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a global Config context instead of passing props along all the components. I do this in preparation of using CCS modules (#165), since we need a way to override the classes, and it's a pain to pass all the possible overrides to each component. It's better to have a global flat config object that gives the custom values. The aim is to use this in apps that use the components, such as https://github.com/hyparam/space