-
Notifications
You must be signed in to change notification settings - Fork 2
Use CSS modules #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CSS modules #188
Conversation
4329c70 to
0fde1db
Compare
ceae0ec to
76a1f29
Compare
platypii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Splitting out smaller components seems like a good thing. The two that feel a little weird are Center and VisuallyHidden which feel more like styles than components. It good for now though. 👍
|
Re VisuallyHidden: it's a common component in any library, and is the current best practice to provide an accessible text without showing it visually (it's more accessible than For Center... I don't like it too much, either. Maybe I'll revisit if I find a better way. |
|
Also @platypii: do you have an opinion on the code structure, ie: Current: three times the same hierarchy in:
versus the proposal:
I created #189 to discuss it. |
fixes #165
Sorry for the review @platypii, it's a very big PR.
I have a proposal for this PR, @platypii:
I think we could reorganize the files a bit, like I did in hightable, loosely following https://www.joshwcomeau.com/react/file-structure/:
It would help find the files quickly, and it would group the styles and components together (this PR will create many CSS module files).