Skip to content

Move to a flat directories structure #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
severo merged 4 commits into from
Apr 1, 2025
Merged

Move to a flat directories structure #191

severo merged 4 commits into from
Apr 1, 2025

Conversation

@severo
Copy link
Contributor

@severo severo commented Apr 1, 2025 •
edited
Loading

fixes #189

  • move the files from components/viewers to components/ (no semantic hierarchy)
  • move every component file to its own subdirectory (App.tsx -> App/App.tsx)
  • move the styles (CSS modules) to these subdirectories (styles/Json.module.css => components/Json/Json.module.css)
  • (maybe) move the tests to these subdirectories (test/Layout.test.tsx => components/Layout/Layout.test.tsx) - it requires tweaking the build process to ignore these files.

@severo severo marked this pull request as ready for review April 1, 2025 08:45
@severo severo merged commit 94586ab into master Apr 1, 2025
4 checks passed
@severo severo deleted the 189-flat-folders-hierarchy branch April 1, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Group the files for each component in the same directory?

2 participants

@severo