Skip to content

reject at least one promise when fetching a row group fails #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severo merged 1 commit into from
Apr 7, 2025
Merged

reject at least one promise when fetching a row group fails #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/tableProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData):
}
})
.catch((error: unknown) => {
console.error('Error fetching row group', error)
const prefix = `Error fetching row group ${groupIndex} (${rowStart}-${rowEnd}).`
console.error(prefix, error)
const reason = `${prefix} ${error}`
// reject the index of the first row (it's enough to trigger the error bar)
data[rowStart]?.index.reject(reason)
})
groups[groupIndex] = true
}
Expand Down