Skip to content

add missing styles #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bleakley merged 2 commits into from
Apr 14, 2025
Merged

add missing styles #215

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b776b6
add missing styles
bleakley Apr 14, 2025
570de8b
update version to 0.2.34
bleakley Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/CellPanel/CellPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { DataFrame, stringify } from 'hightable'
import { useEffect, useState } from 'react'
import ContentWrapper from '../ContentWrapper/ContentWrapper.js'
import SlideCloseButton from '../SlideCloseButton/SlideCloseButton.js'
import styles from '../TextView/TextView.module.css'

interface ViewerProps {
df: DataFrame
Expand Down Expand Up @@ -56,6 +57,6 @@ export default function CellPanel({ df, row, col, setProgress, setError, onClose
</>

return <ContentWrapper headers={headers}>
<code className="text">{text}</code>
<code className={styles.textView}>{text}</code>
Copy link
Contributor

@severo severo Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, well spotted. Thanks for fixing it

Copy link
Contributor

@severo severo Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, we still have an issue here:

hyperparam-cli/src/components/Cell/Cell.tsx

Line 72 in 9b622ef

<pre className="viewer text">{text}</pre>

I'll send a PR

Copy link
Contributor

@severo severo Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#216

</ContentWrapper>
}
2 changes: 1 addition & 1 deletion src/components/TextView/TextView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default function TextView({ source, setError }: ViewerProps) {

// Simple text viewer
return <ContentWrapper content={content} headers={headers} isLoading={isLoading}>
{content && <code className={cn(styles.text, customClass?.textView)}>
{content && <code className={cn(styles.textView, customClass?.textView)}>
{content.text}
</code>}
</ContentWrapper>
Expand Down