Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@types/node": "22.14.1",
"@types/react": "19.1.2",
"@types/react-dom": "19.1.2",
"@vitejs/plugin-react": "4.3.4",
"@vitejs/plugin-react": "4.4.1",
"@vitest/coverage-v8": "3.1.2",
"eslint": "9.25.1",
"eslint-plugin-react": "7.37.5",
Expand Down
2 changes: 1 addition & 1 deletion src/components/Page/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface Navigation {
row?: number
}

interface PageProps {
export interface PageProps {
source: Source,
navigation?: Navigation,
}
Expand Down
35 changes: 34 additions & 1 deletion src/components/index.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,51 @@
import AvroView from './AvroView/AvroView.js'
import Breadcrumb from './Breadcrumb/Breadcrumb.js'
import Cell from './Cell/Cell.js'
import CellPanel from './CellPanel/CellPanel.js'
import ContentWrapper from './ContentWrapper/ContentWrapper.js'
import Dropdown from './Dropdown/Dropdown.js'
import ErrorBar from './ErrorBar/ErrorBar.js'
import File from './File/File.js'
import Folder from './Folder/Folder.js'
import ImageView from './ImageView/ImageView.js'
import Json from './Json/Json.js'
import JsonView from './JsonView/JsonView.js'
import Layout from './Layout/Layout.js'
import Markdown from './Markdown/Markdown.js'
import MarkdownView from './MarkdownView/MarkdownView.js'
import Page from './Page/Page.js'
import ParquetView from './ParquetView/ParquetView.js'
import ProgressBar from './ProgressBar/ProgressBar.js'
import SlidePanel from './SlidePanel/SlidePanel.js'
import Spinner from './Spinner/Spinner.js'
import TextView from './TextView/TextView.js'
import Viewer from './Viewer/Viewer.js'
export { Breadcrumb, Cell, ContentWrapper, Dropdown, ErrorBar, File, Folder, ImageView, Layout, Markdown, MarkdownView, Page, ParquetView, SlidePanel, Spinner, TextView, Viewer }
import VisuallyHidden from './VisuallyHidden/VisuallyHidden.js'
import Welcome from './Welcome/Welcome.js'

export {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this format is better

AvroView,
Breadcrumb,
Cell,
CellPanel,
ContentWrapper,
Dropdown,
ErrorBar,
File,
Folder,
ImageView,
Json,
JsonView,
Layout,
Markdown,
MarkdownView,
Page,
ParquetView,
ProgressBar,
SlidePanel,
Spinner,
TextView,
Viewer,
VisuallyHidden,
Welcome,
}
2 changes: 1 addition & 1 deletion src/lib/tableProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData):
// Initialize with resolvable promises
for (let i = rowStart; i < rowEnd; i++) {
data[i] = resolvableRow(header)
data[i]?.index.resolve(i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

}
parquetQueryWorker({ from, metadata, rowStart, rowEnd })
.then((groupData) => {
Expand All @@ -59,7 +60,6 @@ export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData):
if (dataRow === undefined) {
throw new Error(`Missing data row for index ${i}`)
}
dataRow.index.resolve(i)
const j = i - rowStart
const row = groupData[j]
if (row === undefined) {
Expand Down