Skip to content

Move Versions dropdown to the end of the row #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severo merged 2 commits into from
Apr 24, 2025
Merged

Move Versions dropdown to the end of the row #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084fed3
Move the Versions dropdown to the end of the row
severo Apr 24, 2025
7f2301b
update dependencies
severo Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"watch:url": "NODE_ENV=development nodemon bin/cli.js https://hyperparam.blob.core.windows.net/hyperparam/starcoderdata-js-00000-of-00065.parquet"
},
"dependencies": {
"hightable": "0.15.0",
"hightable": "0.15.1",
"hyparquet": "1.12.1",
"hyparquet-compressors": "1.1.1",
"icebird": "0.2.0",
Expand Down Expand Up @@ -81,12 +81,12 @@
"eslint-plugin-storybook": "0.12.0",
"globals": "16.0.0",
"jsdom": "26.1.0",
"nodemon": "3.1.9",
"nodemon": "3.1.10",
"npm-run-all": "4.1.5",
"storybook": "8.6.12",
"typescript": "5.8.3",
"typescript-eslint": "8.31.0",
"vite": "6.3.2",
"vite": "6.3.3",
"vitest": "3.1.2"
},
"eslintConfig": {
Expand Down
4 changes: 2 additions & 2 deletions src/components/Breadcrumb/Breadcrumb.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/* file path */
.path {
margin: 0 2px;
margin-right: 4px;
margin-right: auto;
min-width: 0;
overflow: auto;
/* TODO(SL): forbid wrap + use an ellipsis instead? */
Expand All @@ -49,7 +49,7 @@
}

.versions {
margin-left: auto;
padding-left: 4px;

[aria-current] {
font-weight: bold;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Breadcrumb/Breadcrumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default function Breadcrumb({ source, children }: BreadcrumbProps) {
<a href={routes?.getSourceRouteUrl?.({ sourceId: part.sourceId }) ?? ''} key={depth}>{part.text}</a>
)}
</div>
{source.fetchVersions && <Versions source={source} />}
{children}
{source.fetchVersions && <Versions source={source} />}
</nav>
}