Virtual row groups of size 1000 #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
parquetDataFramefunction. This function would fetch and decode by row group. This made sense since we basically need to download the whole rowgroup anyway.The problem is that for files with very large row groups, even after downloading, decoding all that data can lag the browser and eat up memory. See hyparam/demos#22 (comment)
This PR changes
parquetDataFrameto use virtual row groups which are max size 1000. Also splits virtual row groups at the natural row group boundaries to avoid fetching two natual row groups at once.Fixes hyparam/demos#22
Previously the parquet file referenced in that issue would take about 15 seconds to load and use 6.5gb of memory on chrome. After the change it loads in 1-2 sec with 545mb memory! 🎉