Add getcolumn to parquetdataframe #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platypii
approved these changes
Jun 20, 2025
Contributor
platypii
left a comment
platypii
left a comment
There was a problem hiding this comment.
Technically this could be made faster if we used parquetReadColumn which would return the column data as typed arrays, instead of transposing into rows and back. It would need to be added to the worker as a message type though. This is fine for now, but something to think about for the future.
https://github.com/hyparam/hyparquet/blob/v1.16.2/src/read.js#L105
severo
approved these changes
Jun 23, 2025
Contributor
There was a problem hiding this comment.
I agree with @platypii that it could be more efficient by avoiding reading all the columns + by using typedarrays, but as we're reworking the DataFrame (hyparam/hightable#208), we will have to refactor again soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.