Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/components/src/lib/tableProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export function parquetDataFrame(from: AsyncBufferFromUrl, metadata: FileMetaDat
const sortCache = new Map<string, Promise<number[]>>()
const data = new Array<ResolvableRow>(Number(metadata.num_rows))
/// ^ warning: the type is a lie at that point, because all rows are undefined for now
/// TODO(SL): improve the type safety
const groups = new Array(metadata.row_groups.length).fill(false)
let groupStart = 0
const groupEnds = metadata.row_groups.map(group => groupStart += Number(group.num_rows))
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/workers/parquetWorkerClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ function getWorker() {
worker.onmessage = ({ data }: { data: ParquetMessage | SortParquetMessage }) => {
const pendingQueryAgent = pending.get(data.queryId)
if (!pendingQueryAgent) {
throw new Error(
console.warn(
`Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`,
)
// TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps.
return
}
if (pendingQueryAgent.kind === 'query') {
const { resolve, reject, onChunk } = pendingQueryAgent
Expand Down
3 changes: 1 addition & 2 deletions src/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ import ReactDOM from 'react-dom/client'
const app = document.getElementById('app')
if (!app) throw new Error('missing app element')

// @ts-expect-error TODO: fix react createRoot type
const root = ReactDOM.createRoot(document.getElementById('app'))
const root = ReactDOM.createRoot(app)
root.render(React.createElement(App))