Skip to content

include the worker in the library (inline, instead of separate chunk) #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severo merged 1 commit into from
Aug 4, 2025
Merged

include the worker in the library (inline, instead of separate chunk) #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/workers/parquetWorkerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import type { ColumnData } from 'hyparquet'
import ParquetWorker from './parquetWorker?worker&inline'
import type { ClientMessage, ParquetQueryWorkerOptions, ParquetReadObjectsWorkerOptions, ParquetReadWorkerOptions, Rows, WorkerMessage } from './types.js'
/// ^ the worker is bundled with the main thread code (inline) which is easier for users to import
/// (no need to copy the worker file to the right place)

let worker: Worker | undefined
let nextQueryId = 0
Expand All @@ -17,7 +20,7 @@ const pendingAgents = new Map<number, Agent>()

function getWorker() {
if (!worker) {
worker = new Worker(new URL('./parquetWorker.js', import.meta.url), { type: 'module' })
worker = new ParquetWorker()
worker.onmessage = ({ data }: { data: WorkerMessage }) => {
const pendingAgent = pendingAgents.get(data.queryId)
if (!pendingAgent) {
Expand Down