Skip to content

pass 'utf8' option to the hyparquet methods #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severo merged 2 commits into from
Aug 15, 2025
Merged

pass 'utf8' option to the hyparquet methods #303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b9eece
pass 'utf8' option to the hyparquet methods
severo Aug 15, 2025
0cb795d
format
severo Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/tableProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { DataFrame, DataFrameEvents, ResolvedValue, UnsortableDataFrame, createEventTarget, sortableDataFrame } from 'hightable'
import type { ColumnData } from 'hyparquet'
import { FileMetaData, parquetSchema } from 'hyparquet'
import { FileMetaData, ParquetReadOptions, parquetSchema } from 'hyparquet'
import { parquetReadWorker } from './workers/parquetWorkerClient.js'
import type { AsyncBufferFrom } from './workers/types.d.ts'

Expand All @@ -21,7 +21,7 @@ interface VirtualRowGroup {
/**
* Convert a parquet file into a dataframe.
*/
export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData): DataFrame {
export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData, options?: Pick<ParquetReadOptions, 'utf8'>): DataFrame {
const { children } = parquetSchema(metadata)
const header = children.map(child => child.element.name)
const eventTarget = createEventTarget<DataFrameEvents>()
Expand Down Expand Up @@ -54,7 +54,7 @@ export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData):

// TODO(SL): pass AbortSignal to the worker?
if (columnsToFetch.length > 0) {
const commonPromise = parquetReadWorker({ from, metadata, rowStart: groupStart, rowEnd: groupEnd, columns: columnsToFetch, onChunk })
const commonPromise = parquetReadWorker({ ...options, from, metadata, rowStart: groupStart, rowEnd: groupEnd, columns: columnsToFetch, onChunk })
columnsToFetch.forEach(column => {
state.set(column, { kind: 'fetching', promise: commonPromise })
})
Expand Down