Skip to content

Conversation

@severo
Copy link
Contributor

@severo severo commented Nov 13, 2024

After this PR:

  • move the common code from this demo and components to a new package?
  • remove the demo code from hyparquet

@severo severo marked this pull request as ready for review November 14, 2024 11:20
@severo severo requested a review from platypii November 14, 2024 11:41
@severo
Copy link
Contributor Author

severo commented Nov 14, 2024

also @platypii: your demo was js, this is ts. Do you think we should also provide an example with pure js? maybe the hyparquet readme is sufficient.

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README still says HighTable.

Typescript is fine, people can figure out the JS easily enough if they want. (Also the hyparquet demo was already a mix of ts and js).

@severo severo merged commit a78392a into master Nov 15, 2024
3 checks passed
@severo severo deleted the add-hyparquet-demo branch November 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants